Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Android Per App Language Support #10994

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add Android Per App Language Support #10994

wants to merge 1 commit into from

Conversation

Arthur-GYT
Copy link

@Arthur-GYT Arthur-GYT commented Apr 24, 2024 •
edited by AudricV
Loading

What is it?

  • Feature (user facing)

Description of the changes in your PR

Feature added by Android 13 to support "natively" app languages.

https://developer.android.com/guide/topics/resources/app-languages

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Apr 24, 2024
@TobiGr TobiGr added the localisation / translation Everything that has to do with translations or Weblate label Apr 24, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@snaik20 snaik20 added the template ignored The user didn't follow the template/instructions (or removed them) label Apr 24, 2024
@Arthur-GYT
Copy link
Author

I don't understand why https://github.com/TeamNewPipe/NewPipe/actions/runs/8814058286/job/24219680455?pr=10994 failed ^^'. Is that normal ?

@Arthur-GYT
Copy link
Author

Any news for this PR ?

TobiGr
TobiGr reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@TobiGr TobiGr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and sorry for the late reply.
NewPipe has an in-app language chooser (settings > content > app language). This one conflicts with the language chosen in the Android app settings when a language is set. The language chosen inside the app is used. Everything works fine when the "system default" option is chosen. Not sure if this is an unwanted behaviour in terms of accessibility.

PS: you might want to rebase to fix the CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiGr TobiGr TobiGr left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
localisation / translation Everything that has to do with translations or Weblate size/small PRs with less than 50 changed lines template ignored The user didn't follow the template/instructions (or removed them)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arthur-GYT @TobiGr @snaik20