-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add playlist description to playlist fragment #10091
Conversation
45320da
to
4c3d8ba
Compare
Kudos, SonarCloud Quality Gate passed! |
Shouldn't you set a height limit where the playlist descriptions are very long? I don't see anything related to a height limit in the view you added. |
Two lines is probably a bit too short, but the idea is very good. For consistency with other UI elements of the app, we may use an alert dialog to display the full description. |
AlertDialog? Are you sure? I'd just expand the description like it is done with comments |
Wouldn't we get the same size issue we want to avoid when the description is expanded? |
No, because in this case it would be the user who chooses to expand the description. I'm assuming tapping on it again would contract it? |
bf41cec
to
7b812ad
Compare
7b812ad
to
b64d603
Compare
I don't think it's that great to have such a small 'Show more' button next to the 'Pop-up' button. Why is it not like comments? |
b64d603
to
62cabf1
Compare
62cabf1
to
85ae20f
Compare
@wb9688 I used the button to explicitly state that there is more content. The problem with the current comment implementation (i.e. three dots as indicator and click for more content) is the bad accessibility. Three dots at the end do not indicate the action that can be taken, a text clearly does. I increased the gap between the playlist actions and the show more button. |
Kudos, SonarCloud Quality Gate passed! |
02bdae6
to
aea00b8
Compare
Kudos, SonarCloud Quality Gate passed! |
44d0a3f
to
d25a8c8
Compare
The description can be expanded / collapsed via a "show more" / "show less" button.
d25a8c8
to
65eb631
Compare
07f531a
to
9ff1b52
Compare
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
What is it?
Description of the changes in your PR
Added the playlist description to the
PlaylistFragment
.Added new utility class
TextEllipsizer
that allows shortening and expanding text inside a TextView.Before/After Screenshots/Screen Record
playlist-description.mp4
Fixes the following issue(s)
Closes #3885
Relies on the following changes
TeamNewPipe/NewPipeExtractor#1061
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence