-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] #347 - HomeView | SearchView 2차 QA 대응 #351
Open
Guryss
wants to merge
11
commits into
main
Choose a base branch
from
Fix/#347
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+95
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ena-isme
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
굳! 수고 많으셨습니다
Guryss
changed the title
[Fix] #347 - HomeView 2차 QA 대응
[Fix] #347 - HomeView | SearchView 2차 QA 대응
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⭐️Issue
close #347
🌟Motivation
🌟Key Changes
HomeVC
viewDidLoad
시UserDefaults
저장viewDidLoad
시점에 유저 정보 조회 API 를 호출합니다.이후 유저 디폴트에
userId
,userNickname
,userGender
값을 저장합니다.해당 데이터 사용할 때엔
private let userNickname = UserDefaults.standard.string(forKey: StringLiterals.UserDefault.userNickname)
이렇게 사용하심 될 것 같아요 🙌
🌟Simulation
2024-11-18.9.47.22.mov
🌟To Reviewer
@hyowon612 유저디폴트값이 잘 사용되고 있는지 홈뷰 - 관심글 내 유저 닉네임 확인 부탁드립니다 🙇♀️
🌟Reference