Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] #347 - HomeView | SearchView 2차 QA 대응 #351

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

Guryss
Copy link
Member

@Guryss Guryss commented Nov 18, 2024

⭐️Issue

close #347

🌟Motivation

  • HomeView 2차 QA 대응 반영했습니다.

🌟Key Changes

HomeVC viewDidLoadUserDefaults 저장

viewDidLoad 시점에 유저 정보 조회 API 를 호출합니다.
이후 유저 디폴트에 userId, userNickname, userGender 값을 저장합니다.

input.viewDidLoadEvent
    .flatMapLatest {
    return self.getUserMeData()
    }
    .subscribe(with: self, onNext: { owner, data in
        UserDefaults.standard.setValue(data.userId, forKey: StringLiterals.UserDefault.userId)
        UserDefaults.standard.setValue(data.nickname, forKey: StringLiterals.UserDefault.userNickname)
        UserDefaults.standard.setValue(data.gender, forKey: StringLiterals.UserDefault.userGender)
    })
    .disposed(by: disposeBag)

해당 데이터 사용할 때엔
private let userNickname = UserDefaults.standard.string(forKey: StringLiterals.UserDefault.userNickname)
이렇게 사용하심 될 것 같아요 🙌

🌟Simulation

홈뷰 탭바 클릭 시 스크롤 최상단으로 이동
Simulator Screen Recording - iPhone SE (3rd generation) - 2024-11-18 at 21 20 38
  • 비로그인 시 로직 수정 - 탐색 탭 보여지도록 && 모든 클릭 이벤트 제한
2024-11-18.9.47.22.mov

🌟To Reviewer

@hyowon612 유저디폴트값이 잘 사용되고 있는지 홈뷰 - 관심글 내 유저 닉네임 확인 부탁드립니다 🙇‍♀️

🌟Reference


@Guryss Guryss self-assigned this Nov 18, 2024
@Guryss Guryss added the guryss label Nov 18, 2024
@Guryss Guryss requested review from Naknakk, hyowon612 and ena-isme and removed request for Naknakk and hyowon612 November 18, 2024 12:51
Copy link
Member

@ena-isme ena-isme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳! 수고 많으셨습니다

@Guryss Guryss changed the title [Fix] #347 - HomeView 2차 QA 대응 [Fix] #347 - HomeView | SearchView 2차 QA 대응 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] HomeView 2차 QA 대응
2 participants