Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Jwt 재발급 API 구현 #25

Merged
merged 6 commits into from
Jan 7, 2024
Merged

[feat] Jwt 재발급 API 구현 #25

merged 6 commits into from
Jan 7, 2024

Conversation

gardening-y
Copy link
Member

Related Issue 📌

close #20

Description ✔️

  • UserService에 Jwt 재발급 비즈니스 로직을 구현하였습니다.
  • UserApiController 클래스의 reissue 메서드를 구현하였습니다.
  • Jwt 재발급 요청 dto로 UserReissueRequest를 구현하였습니다.

Copy link
Member

@SunwoongH SunwoongH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

@@ -44,4 +45,11 @@ public ResponseEntity<ApiResponse<?>> withdraw(@UserId final Long userId) {
userService.withdraw(userId);
return ApiResponseUtil.success(SuccessMessage.OK);
}

@PatchMapping("/reissue")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Http Method 확인 한번 부탁드립니다!

@@ -44,4 +45,11 @@ public ResponseEntity<ApiResponse<?>> withdraw(@UserId final Long userId) {
userService.withdraw(userId);
return ApiResponseUtil.success(SuccessMessage.OK);
}

@PatchMapping("/reissue")
public ResponseEntity<ApiResponse<?>> reissue(@RequestHeader("Authorization") final String refreshtoken,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Authorization"과 같이 반복적으로 사용되는 문자열을 전역 상수로 관리해도 좋을 것 같습니다.

@gardening-y gardening-y merged commit 19c64db into develop Jan 7, 2024
1 check passed
@SunwoongH SunwoongH deleted the feature/20 branch July 11, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Jwt 재발급 API 구현
2 participants