Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2188 - adds checking whether attachment has a proper taskId set when updating a task. #2355

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

nyuuyn
Copy link
Contributor

@nyuuyn nyuuyn commented Aug 2, 2023

Closes issue #2188

Release Notes:

If attachments are set a wrong Task Id the API will respond with a BadRequest

For the submitter:

Verified by the reviewer:

Copy link
Contributor

@jamesrdi jamesrdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is similar to the PR here: #1876

@nyuuyn nyuuyn force-pushed the TSK-2188 branch 3 times, most recently from 5f80b09 to 26bda6d Compare August 14, 2023 16:19
@nyuuyn nyuuyn changed the title adds checking whether attachment has a proper taskId set when creating a task. Closes #2188 - adds checking whether attachment has a proper taskId set when updating a task. Aug 15, 2023
@nyuuyn
Copy link
Contributor Author

nyuuyn commented Aug 15, 2023

This PR is similar to the PR here: #1876

I added/changed the code to incorporate the changes in the old PR, such as, checking the attachments taskId when updating a task

@nyuuyn nyuuyn force-pushed the TSK-2188 branch 2 times, most recently from e96b9be to 7a15e78 Compare September 22, 2023 08:48
…askId set when creating/updating a task.

Signed-off-by: Kálmán Képes <[email protected]>
@ryzheboka ryzheboka merged commit 1528d87 into Taskana:master Sep 26, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit Hooks won't work without JIRA Tickets
3 participants