Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #2338 - Add query of tasks without owner #2343

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Closes #2338 - Add query of tasks without owner #2343

merged 1 commit into from
Aug 10, 2023

Conversation

jamesrdi
Copy link
Contributor

@jamesrdi jamesrdi commented Jul 28, 2023 •
edited
Loading

https://sonarcloud.io/summary/new_code?id=jamesrdi_taskana&branch=TSK-2338

Release Notes:

For the submitter:

Verified by the reviewer:

ryzheboka
ryzheboka requested changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@ryzheboka ryzheboka left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests in "TaskQueryImplAccTest". We also need tests for combination of parameters, so please look up where you can write these tests. Could you add the Sonarcloud link?

common/taskana-common/src/main/java/pro/taskana/common/internal/util/SqlProviderUtil.java Outdated Show resolved Hide resolved
lib/taskana-core/src/main/java/pro/taskana/task/internal/TaskQueryImpl.java Outdated Show resolved Hide resolved
rest/taskana-rest-spring/src/main/java/pro/taskana/common/rest/util/QueryParamsValidator.java Show resolved Hide resolved
rest/taskana-rest-spring/src/main/java/pro/taskana/task/rest/TaskQueryFilterParameter.java Outdated Show resolved Hide resolved
rest/taskana-rest-spring/src/main/java/pro/taskana/task/rest/TaskQueryFilterParameter.java Outdated Show resolved Hide resolved
rest/taskana-rest-spring/src/test/java/pro/taskana/task/rest/TaskControllerIntTest.java Outdated Show resolved Hide resolved
rest/taskana-rest-spring/src/test/java/pro/taskana/task/rest/TaskControllerIntTest.java Outdated Show resolved Hide resolved
rest/taskana-rest-spring/src/test/java/pro/taskana/task/rest/TaskControllerIntTest.java Outdated Show resolved Hide resolved
rest/taskana-rest-spring/src/test/java/pro/taskana/task/rest/TaskControllerIntTest.java Outdated Show resolved Hide resolved
rest/taskana-rest-spring/src/test/java/pro/taskana/task/rest/TaskControllerIntTest.java Outdated Show resolved Hide resolved
@jamesrdi jamesrdi force-pushed the TSK-2338 branch 13 times, most recently from 2a511d5 to d5f46fb Compare August 8, 2023 07:56
@jamesrdi jamesrdi force-pushed the TSK-2338 branch 4 times, most recently from 67005ad to 890a6c3 Compare August 10, 2023 08:32
ryzheboka
ryzheboka previously approved these changes Aug 10, 2023
View reviewed changes
@ryzheboka ryzheboka merged commit 7e2f933 into Taskana:master Aug 10, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzheboka ryzheboka ryzheboka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commit Hooks won't work without JIRA Tickets
2 participants
@jamesrdi @ryzheboka