Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query-core): don't finalizeThenable of different queries #8171

Merged
merged 5 commits into from
Oct 12, 2024
Merged

fix(query-core): don't finalizeThenable of different queries #8171

merged 5 commits into from
Oct 12, 2024

Commits on Oct 12, 2024

  1. fix(query-core): don't finalizeThenable of different queries 

    if we have multiple promises in-flight, once they resolve, we need to make sure to not finalize with data / error from a different key; otherwise, we might see intermediate data of non-matching keys
    @TkDodo
    TkDodo committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    5408355 View commit details
    Browse the repository at this point in the history

  2. chore: extract promise tests to their own file

    @TkDodo
    TkDodo committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    aa1d4d6 View commit details
    Browse the repository at this point in the history

  3. test: add a test case for not resolving with intermediate data

    @TkDodo
    TkDodo committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    c1f5016 View commit details
    Browse the repository at this point in the history

  4. fix: only stop finalizing if we were previously in pending state 

    this makes sure we can read stale data from entries when switching to them immediately
    @TkDodo
    TkDodo committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    96661a7 View commit details
    Browse the repository at this point in the history

  5. chore: add another test for background updates

    @TkDodo
    TkDodo committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    a4a2cf7 View commit details
    Browse the repository at this point in the history