Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTM-1221: common interface for creating tasks #979

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

mprins
Copy link
Contributor

@mprins mprins commented Oct 8, 2024

HTM-1221 Powered by Pull Request Badge

All we really need is a JobDataMap with some required keys for [HTM-1221 I think, we may extract an abstract superclass at some point, also, the current job example is not interruptable

resolves part of HTM-1227 by providing a logging job listener and a logging trigger listener.

@mprins mprins added the enhancement New feature or request label Oct 8, 2024
@mprins mprins self-assigned this Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 77.53623% with 31 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...lormap/api/scheduling/DebugLoggingJobListener.java 56% 10 Missing and 3 partials ⚠️
...ap/api/scheduling/DebugLoggingTriggerListener.java 70% 4 Missing and 2 partials ⚠️
...rmap/api/controller/admin/TaskAdminController.java 80% 5 Missing ⚠️
...ava/org/tailormap/api/scheduling/TMJobDataMap.java 75% 5 Missing ⚠️
...ain/java/org/tailormap/api/scheduling/PocTask.java 91% 2 Missing ⚠️

Impacted file tree graph

@@          Coverage Diff          @@
##             main   #979   +/-   ##
=====================================
- Coverage      78%    77%   -0%     
- Complexity     78     82    +4     
=====================================
  Files         103    107    +4     
  Lines        4720   4818   +98     
  Branches      439    440    +1     
=====================================
+ Hits         3639   3708   +69     
- Misses        852    877   +25     
- Partials      229    233    +4     
Files with missing lines Coverage Δ Complexity Δ
...rmap/api/configuration/SchedulerConfiguration.java 100% <100%> (ø) 0 <0> (?)
...lormap/api/configuration/dev/PopulateTestData.java 91% <100%> (ø) 0 <0> (ø)
...java/org/tailormap/api/scheduling/TaskCreator.java 81% <100%> (ø) 0 <0> (?)
...ain/java/org/tailormap/api/scheduling/PocTask.java 93% <91%> (-7%) 0 <0> (ø)
...rmap/api/controller/admin/TaskAdminController.java 87% <80%> (-4%) 0 <0> (ø)
...ava/org/tailormap/api/scheduling/TMJobDataMap.java 75% <75%> (ø) 4 <4> (?)
...ap/api/scheduling/DebugLoggingTriggerListener.java 70% <70%> (ø) 0 <0> (?)
...lormap/api/scheduling/DebugLoggingJobListener.java 56% <56%> (ø) 0 <0> (?)

Copy link

github-actions bot commented Oct 8, 2024

Test Results

277 tests  ±0   276 ✅ ±0   2m 52s ⏱️ -10s
 29 suites ±0     1 💤 ±0 
 29 files   ±0     0 ❌ ±0 

Results for commit 3ac18a7. ± Comparison against base commit d2148ac.

♻️ This comment has been updated with latest results.

@mprins mprins changed the title [WIP] HTM-1221: common interface for creating tasks HTM-1221: common interface for creating tasks Oct 10, 2024
@mprins mprins merged commit 47901fe into main Oct 10, 2024
25 checks passed
@mprins mprins deleted the HTM-1221_task_interface branch October 10, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants