Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front controller fixes #1098

Merged
merged 5 commits into from
Dec 24, 2024
Merged

Front controller fixes #1098

merged 5 commits into from
Dec 24, 2024

Conversation

matthijsln
Copy link
Contributor

@matthijsln matthijsln commented Dec 23, 2024

  • Do not set cache param for resourceChain() method for locale-dependent index.html
  • Add caching headers for static resources with hashed name (js, css, map) and icons/fonts
  • Code improvements

Copy link

codecov bot commented Dec 23, 2024

❌ 232 Tests Failed:

Tests completed Failed Passed Skipped
280 232 48 0
View the top 3 failed tests by shortest run time
org.tailormap.api.controller.FeaturesControllerIntegrationTest filterTest(String, String, int)[42]
Stack Traces | 0s run time
No failure message available
org.tailormap.api.controller.FeaturesControllerIntegrationTest should_return_non_empty_featurecollections_for_valid_pages_from_database(String, int)[1]
Stack Traces | 0s run time
No failure message available
org.tailormap.api.controller.UploadsControllerIntegrationTest testBadRequest
Stack Traces | 0s run time
No failure message available

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Copy link

github-actions bot commented Dec 23, 2024

Test Results

233 tests   - 67     1 ✅  - 297   25s ⏱️ - 3m 34s
 32 suites ± 0     0 💤  -   2 
 32 files   ± 0     0 ❌ ±  0   232 🔥 +232 

For more details on these errors, see this check.

Results for commit 47e98ef. ± Comparison against base commit 646692e.

This pull request removes 74 and adds 7 tests. Note that renamed tests count towards both.
org.tailormap.api.controller.EditFeatureControllerIntegrationTest ‑ testDeleteExistingFeatureMsSql
org.tailormap.api.controller.EditFeatureControllerIntegrationTest ‑ testDeleteExistingFeatureOrcl
org.tailormap.api.controller.EditFeatureControllerIntegrationTest ‑ testDeleteExistingFeaturePG
org.tailormap.api.controller.EditFeatureControllerIntegrationTest ‑ testDeleteExistingFeatureWFS
org.tailormap.api.controller.EditFeatureControllerIntegrationTest ‑ testDeleteNonExistentFeature
org.tailormap.api.controller.EditFeatureControllerIntegrationTest ‑ testDeleteWhenLayerDoesNotExist
org.tailormap.api.controller.EditFeatureControllerIntegrationTest ‑ testDuplicatePrimaryKeyPG
org.tailormap.api.controller.EditFeatureControllerIntegrationTest ‑ testGetIsUnsupported
org.tailormap.api.controller.EditFeatureControllerIntegrationTest ‑ testNonEditablePatch
org.tailormap.api.controller.EditFeatureControllerIntegrationTest ‑ testPatchForeignCRSPG
…
org.tailormap.api.controller.EditFeatureControllerIntegrationTest ‑ Unknown test
org.tailormap.api.controller.GeoServiceProxyControllerIntegrationTest ‑ Unknown test
org.tailormap.api.controller.admin.ApplicationAdminControllerIntegrationTest ‑ Unknown test
org.tailormap.api.controller.admin.PasswordValidationControllerIntegrationTest ‑ Unknown test
org.tailormap.api.controller.admin.SolrAdminControllerIntegrationTest ‑ Unknown test
org.tailormap.api.controller.admin.TaskAdminControllerIntegrationTest ‑ Unknown test
org.tailormap.api.controller.admin.UnreachableSolrAdminControllerIntegrationTest ‑ Unknown test

♻️ This comment has been updated with latest results.

@matthijsln matthijsln marked this pull request as ready for review December 23, 2024 19:25
@mprins mprins force-pushed the front-controller-fixes branch from 47e98ef to 9f9f51e Compare December 24, 2024 08:54
@mprins mprins enabled auto-merge (squash) December 24, 2024 08:54
@mprins mprins merged commit 1cb9677 into main Dec 24, 2024
20 of 24 checks passed
@mprins mprins deleted the front-controller-fixes branch December 24, 2024 09:01
@mprins
Copy link
Contributor

mprins commented Dec 24, 2024

@matthijsln Integrations tests fail with "2024-12-24T09:13:33.809Z WARN 5221 --- [ main] o.s.w.c.s.GenericWebApplicationContext : Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'indexHtmlTransformer': Injection of autowired dependencies failed"

and this was auto-merged because the integration tests/verify are no longer required?...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants