Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTM-1321: Make Solr schema creation more robust #1029

Merged
merged 1 commit into from
Nov 12, 2024
Merged

HTM-1321: Make Solr schema creation more robust #1029

merged 1 commit into from
Nov 12, 2024

Conversation

mprins
Copy link
Contributor

@mprins mprins commented Nov 12, 2024

HTM-1321 Powered by Pull Request Badge

@mprins mprins added the bug Something isn't working label Nov 12, 2024
@mprins mprins self-assigned this Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 91.52542% with 5 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/main/java/org/tailormap/api/solr/SolrHelper.java 92% 4 Missing and 1 partial ⚠️

Impacted file tree graph

@@          Coverage Diff           @@
##             main   #1029   +/-   ##
======================================
- Coverage      76%     76%   -0%     
  Complexity     86      86           
======================================
  Files         113     113           
  Lines        5222    5237   +15     
  Branches      460     459    -1     
======================================
+ Hits         3920    3931   +11     
- Misses       1057    1061    +4     
  Partials      245     245           
Files with missing lines Coverage Δ Complexity Δ
...c/main/java/org/tailormap/api/solr/SolrHelper.java 82% <92%> (-<1%) 0 <0> (ø)

Copy link

github-actions bot commented Nov 12, 2024

Test Results

292 tests  ±0   291 ✅ ±0   3m 19s ⏱️ +5s
 31 suites ±0     1 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit 6e9bfdb. ± Comparison against base commit b836cc2.

♻️ This comment has been updated with latest results.

@mprins mprins marked this pull request as ready for review November 12, 2024 14:10
@mprins mprins changed the title HTM-1321: Make Solr schema creating more robust HTM-1321: Make Solr schema creation more robust Nov 12, 2024
@mprins mprins merged commit ec1cef4 into main Nov 12, 2024
26 checks passed
@mprins mprins deleted the HTM-1321 branch November 12, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant