use LAST_RESULT_KEY

Tailormap · Nov 5, 2024 · 5bfc0db · 5bfc0db
1 parent e350c9f
commit 5bfc0db
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/org/tailormap/api/controller/admin/TaskAdminController.java b/src/main/java/org/tailormap/api/controller/admin/TaskAdminController.java
@@ -247,7 +247,7 @@ public ResponseEntity<Object> details(@PathVariable TaskType type, @PathVariable
                   "nextFireTimes", TriggerUtils.computeFireTimes((OperableTrigger) cron, null, 5))
               .putPOJO(Task.STATE_KEY, scheduler.getTriggerState(trigger.getKey()))
               .putPOJO("progress", result[0])
-              .put("lastResult", jobDataMap.getString("lastResult"))
+              .put(Task.LAST_RESULT_KEY, jobDataMap.getString(Task.LAST_RESULT_KEY))
               .putPOJO("jobData", jobDataMap));
     } catch (SchedulerException e) {
       throw new ResponseStatusException(HttpStatus.INTERNAL_SERVER_ERROR, "Error getting task", e);

diff --git a/src/main/java/org/tailormap/api/scheduling/FailingPocTask.java b/src/main/java/org/tailormap/api/scheduling/FailingPocTask.java
@@ -39,7 +39,7 @@ protected void executeInternal(JobExecutionContext context) throws JobExecutionE
       throw new UnsupportedOperationException("Failing POC task failed.");
     } catch (Exception e) {
       logger.error("Failing POC task failed.", e);
-      jobDataMap.put("lastResult", "POC task executed unsuccessfully");
+      jobDataMap.put(Task.LAST_RESULT_KEY, "POC task executed unsuccessfully");
       context.setResult("POC task executed unsuccessfully");
       throw new JobExecutionException(e);
     }

diff --git a/src/main/java/org/tailormap/api/scheduling/IndexTask.java b/src/main/java/org/tailormap/api/scheduling/IndexTask.java
@@ -100,7 +100,7 @@ protected void executeInternal(@NonNull JobExecutionContext context)
       searchIndex.setStatus(SearchIndex.Status.ERROR).setComment(e.getMessage());
       persistedJobData.put("lastExecutionFinished", null);
       persistedJobData.put(
-          "lastResult", "Index task failed with " + e.getMessage() + ". Check logs for details");
+          Task.LAST_RESULT_KEY, "Index task failed with " + e.getMessage() + ". Check logs for details");
       searchIndexRepository.save(searchIndex);
       context.setResult("Error indexing. Check logs for details.");
       throw new JobExecutionException("Error indexing", e);

diff --git a/src/main/java/org/tailormap/api/scheduling/PocTask.java b/src/main/java/org/tailormap/api/scheduling/PocTask.java
@@ -62,7 +62,7 @@ protected void executeInternal(@NonNull JobExecutionContext context) {
     int executions = (1 + (int) mergedJobDataMap.getOrDefault("executions", 0));
     jobDataMap.put("executions", executions);
     jobDataMap.put("lastExecutionFinished", Instant.now());
-    jobDataMap.put("lastResult", "POC task executed successfully");
+    jobDataMap.put(Task.LAST_RESULT_KEY, "POC task executed successfully");
     context.setResult("POC task executed successfully");
 
     setFoo("foo executed: " + executions);