Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add support for PHP 8.4 #32

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] Add support for PHP 8.4 #32

wants to merge 2 commits into from

Commits on Oct 3, 2024

  1. [TASK] Fix PHP 8.4 compatibility 

    Defaulting to null without being nullable (?Foo) is deprecated for typed
parameters in PHP 8.4

Therefore following changes have been made:

 * `IncludeFile`: We actually do not need a Filesystem parameter for
   `IncludeFile. It has never been passed and is therefore removed.
 * `ClassAliasMapGenerator` `Config` parameter is unused (was never set)
   since the introduction in a63a582.
   It is removed.
 * `ClassAliasMapGenerator` `IO` parameter has always been set
   and is therefore now a required parameter.

Additional the call to str_getcsv is adapted to set all optional
arguments as the defaults will change in PHP >= 9 and PHP 8.4
deprecated the omission of the optional arguments.

Fixes TYPO3#31
    @bnf
    bnf committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d3cfe8c View commit details
    Browse the repository at this point in the history

  2. [TASK] Test PHP 8.3 and 8.4 

    Also drop prophecy workarounds since PHP 8.2 compatibility
has been enabled upstream.
    @bnf
    bnf committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    faf06e3 View commit details
    Browse the repository at this point in the history