Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a secondary ear slot to the loadout menu. #659

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

Cameron-The-Raven
Copy link
Contributor

@Cameron-The-Raven Cameron-The-Raven commented Nov 15, 2024

Adds a second ear slot. Titled 'Horns' but can simply function to let people have two sets of ears if they don't want to have both ears and horns!

Attributions:
Port of VS PR#16513 'Adds a second ear slot.'
Ports Part of VS PR #16109 relevant part: '(fix: BodyDesigner ears, tail and wings option)'
Ports over VS PR #16553 (sanity checks secondary ear colours)

Very minor edits to the original code. (Changing one bold to for example), putting the DNA in DNA2,

This has all the parts MINUS the TGUI part (AppearanceChanger & BodyDesigner).
I don't know TGUI well enough to get those to work.
And the appearance changer throws a bunch of runtimes on a fresh branch WITHOUT any adjustments, so it's already borked from what I can see.

Port of VS PR#16513 'Adds a second ear slot.'
Ports Part of VS PR #16109 relevant part: '(fix: BodyDesigner ears, tail and wings option)'
Ports over VS PR #16553 (sanity checks secondary ear colours)

Very minor edits to the original code. (Changing one bold to <b> </b> for example)

This has all the parts MINUS the TGUI part (AppearanceChanger & BodyDesigner).
I don't know TGUI well enough to get those to work.
@Cameron-The-Raven Cameron-The-Raven changed the title Adds a secondary ear slot to the loadout menu. [TEMP DNM] Adds a secondary ear slot to the loadout menu. Nov 16, 2024
@Cameron-The-Raven
Copy link
Contributor Author

I put this through the wringer to make sure it wasn't going to do anything crazy to saves, wouldn't cause runtimes, wouldn't crash, etc.

Tested:
Having no ears.
Having 1 set of ears.
Having just 'horns'
Saving, selecting another save file, then re-selecting it.
Exiting and re-opening the save file
Saving, restarting the server, re-opening the save file

Photos:
image
image
2024-11-16_00-05-42

@Very-Soft Very-Soft merged commit 3df24dd into TS-Rogue-Star:master Nov 17, 2024
5 checks passed
@Cameron-The-Raven Cameron-The-Raven deleted the second_ears branch November 27, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants