Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master] Fix: multisite admin menu and notices #252

Closed
wants to merge 2 commits into from

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Jan 13, 2015

As on multisite by default plugins can only be installed from the network admin, it makes more sense showing the TGM page in the network admin and not in the site admin.

On that same note, the admin notices should be shown on the network admin too.

Related #228, #239

Sister-PR to PR #247

As on multisite by default plugins can only be installed from the network admin, it makes more sense showing the TGM page in the network admin and not in the site admin.

On that same note, the admin notices should be shown on the network admin too.

Related TGMPA#228, TGMPA#239
As the notices are now only shown on network admin for multisite, thickbox does not need to be loaded on single sites in a multi-site context.

(cherry picked from commit a6af4ef)

Conflicts:
	class-tgm-plugin-activation.php
@jrfnl
Copy link
Contributor Author

jrfnl commented Jan 17, 2015

On second thought: This should not be merged as is. The logic is valid for TGM being included with a plugin, however, when TGM is enabled for a theme, the logic does not hold.

The problem then is that when on multisite:

  • The theme used is site-specific, so whether TGM is active will differ per site.
  • However plugins can normally only be installed from the network admin and not every site-admin has access to the network admin, which causes an issue.
  • Similarly, as the theme loaded when on the network admin is the theme associated with site 1, it will be difficult to detect when to show a network admin a notice about installing plugins via TGM needed for themes in use by child-sites other than site 1.

@daronspence
Copy link

Is this problem going to be addressed? Or are MU users SOL?

@jrfnl
Copy link
Contributor Author

jrfnl commented Apr 7, 2015

@daronspence This will be addressed and probably quite soon too.

@daronspence
Copy link

@jrfnl I've used the $ms_hook variable you defined in one of your commits and it seems to be working nicely for my needs. I've got the class semi-heavily customized at this point so it's not a huge deal for me at this point, though I'm sure it would certainly benefit others!

@jrfnl jrfnl deleted the master-ms-admin-menu branch April 22, 2015 06:25
@jrfnl jrfnl mentioned this pull request May 6, 2015
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants