Propose: Allow custom scripts to be loaded from a JSON file. #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would more neat to load custom scripts from a JSON file instead of modifying
customScripts.lua
, similar to how via data files are loaded. It's also configurable from theconfig
table and obeys the order from the JSON file.Currently, the custom scripts are loaded
OnServerPostInit
, I couldn't think of a better place of where scripts should be loaded. This would also resolve this issue #80I'm open to any suggestions.
Here's what the JSON file would look like.