Ontology update. GWP concept included #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarijo
reviewed
Jan 14, 2025
development/ecfo.owl
Outdated
| rdfs:label "GWP Conversion Factor"@en . | ||
|
|
||
| ### https://w3id.org/ecfo#hasGWP | ||
| :GWP rdf:type owl:ObjectProperty ; |
There was a problem hiding this comment.
Suggested change
| :GWP rdf:type owl:ObjectProperty ; | |
| :gwp rdf:type owl:ObjectProperty ; | |
We use non capital letters for properties
dgarijo
reviewed
Jan 14, 2025
development/ecfo.owl
Outdated
| @@ -375,6 +375,17 @@ foaf:Organization rdf:type owl:Class . | |||
| rdfs:comment "A generic class to describe a category/tag that ecfo:EmissionFactor. Use ecfo:hasTag to link the category/tag and rdf:value to provide the name of the category. A single ecfo:EmissionFactor may refer to multiple tags. To identify individual conversion factors a union of tags should be considered." ; | |||
| rdfs:label "Tag" . | |||
|
|
|||
| ### https://w3id.org/ecfo#GWPConversionFactor | |||
| :CF_gwp rdf:type owl:Class ; | |||
There was a problem hiding this comment.
Suggested change
| :CF_gwp rdf:type owl:Class ; | |
| :GlobalWarmingPotentialConversionFactor rdf:type owl:Class ; |
There was a problem hiding this comment.
to be consistent with EmissionConversionFactor
|
Please see the changes requested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all changes made during the Bachelor thesis are uploaded