Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test 5 - Demo #22

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
9414b21
Update main.tf
fatihtokus Jan 14, 2023
c08a13b
Update main.tf
fatihtokus Jan 14, 2023
b6fb763
Create test1.tf
fatihtokus Jan 14, 2023
5836af7
Update main.yml
fatihtokus Jan 14, 2023
adad4a7
Update main.yml
fatihtokus Jan 14, 2023
e10f6c6
Update main.yml
fatihtokus Jan 14, 2023
3ac456c
Update main.yml
fatihtokus Jan 14, 2023
208f73e
Update main.yml
fatihtokus Jan 14, 2023
4626a9e
Update main.yml
fatihtokus Jan 14, 2023
121f6ec
Update main.yml
fatihtokus Jan 14, 2023
7754aab
Update main.yml
fatihtokus Jan 14, 2023
54cc897
Update main.yml
fatihtokus Jan 14, 2023
422f7da
Update main.yml
fatihtokus Jan 14, 2023
b057bd5
Update main.yml
fatihtokus Jan 14, 2023
6ad877d
Update main.yml
fatihtokus Jan 14, 2023
8fdf384
Update main.yml
fatihtokus Jan 14, 2023
c35eb15
Update main.yml
fatihtokus Jan 16, 2023
f3179f3
Update main.yml
fatihtokus Jan 16, 2023
48c4d81
Update main.yml
fatihtokus Jan 16, 2023
1ebf1f0
Update main.yml
fatihtokus Jan 22, 2023
d76c136
Update main.yml
fatihtokus Jan 25, 2023
b6ee154
Update main.yml
fatihtokus Jan 25, 2023
9fbdcd5
Update main.yml
fatihtokus Jan 25, 2023
3290d7c
Update main.yml
fatihtokus Jan 25, 2023
e72ed3d
Update main.yml
fatihtokus Jan 27, 2023
223567d
Update main.yml
fatihtokus Jan 27, 2023
b076624
Update main.yml
fatihtokus Jan 27, 2023
64aa462
Update main.yml
fatihtokus Jan 27, 2023
82cf7a1
wip
fatihtokus Feb 1, 2023
07fe3fd
wip
fatihtokus Feb 1, 2023
360f928
wip
fatihtokus Feb 1, 2023
0dc63d0
wip
fatihtokus Feb 1, 2023
25232b2
wip
fatihtokus Feb 3, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 42 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,51 @@ jobs:
- name: Clone repo
uses: actions/checkout@master
- name: tfsec
id: tfsec
uses: aquasecurity/[email protected]
with:
working_directory: ''
tfsec_args: --soft-fail
tfsec_args: --soft-fail --no-ignores --include-passed
github_token: ${{ github.token }}
- name: Upload math result for job 1
if: always()
uses: actions/upload-artifact@v3
with:
name: tf_results
path: results.json
- name: Print the final result
if: always()
shell: bash
run: |
value=`cat results.json`
echo The result is $value
name: A job to say hello
- name: pull_request
run: echo ${{github.event.pull_request.url}}
- name: tf-visualizer-action
if: always()
id: hello
uses: fatihtokus/[email protected]
with:
pull-request: ${{github.event.pull_request.url}}
github-token: ${{ github.token }}
- name: Download math result for job 2
if: always()
uses: actions/download-artifact@v3
with:
name: tf_results
- name: outputtest1
if: always()
run: |
ls
echo "mix-ecto_create='ABC'" >> $GITHUB_OUTPUT
id: run_tests
- name: outputtest2
if: always()
run: |
echo ${{steps.run_tests.outputs.mix-ecto_create}}
echo ${{join(steps.run_tests.outputs.*, '\n')}}
echo ${{join(steps.tfsec.outputs.*, '\n')}}
# create_issue:
# runs-on: ubuntu-latest
# permissions:
Expand All @@ -33,6 +73,7 @@ jobs:
# "body": "This issue was automatically created by the GitHub Action workflow **${{ github.workflow }}**. \n\n The commit hash was: _${{ github.sha }}_."
# }' \
# --fail
#
# hello_world_job:
# runs-on: ubuntu-latest
# permissions:
Expand Down
4 changes: 4 additions & 0 deletions test1.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
resource "aws_s3_bucket" "my-bucket-test1" {
bucket = "foobar"
acl = "private"
}
Comment on lines +1 to +4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ tfsec found a HIGH severity issue from rule aws-s3-block-public-acls:

No public access block so not blocking public acls

More information available here and here

Comment on lines +1 to +4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ tfsec found a HIGH severity issue from rule aws-s3-block-public-policy:

No public access block so not blocking public policies

More information available here and here

Comment on lines +1 to +4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ tfsec found a HIGH severity issue from rule aws-s3-enable-bucket-encryption:

Bucket does not have encryption enabled

More information available here and here

Comment on lines +1 to +4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ tfsec found a MEDIUM severity issue from rule aws-s3-enable-bucket-logging:

Bucket does not have logging enabled

More information available here and here

Comment on lines +1 to +4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ tfsec found a MEDIUM severity issue from rule aws-s3-enable-versioning:

Bucket does not have versioning enabled

More information available here and here

Comment on lines +1 to +4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ tfsec found a HIGH severity issue from rule aws-s3-encryption-customer-key:

Bucket does not encrypt data with a customer managed key.

More information available here and here

Comment on lines +1 to +4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ tfsec found a HIGH severity issue from rule aws-s3-ignore-public-acls:

No public access block so not ignoring public acls

More information available here and here

Comment on lines +1 to +4
Copy link

@github-actions github-actions bot Jan 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ tfsec found a HIGH severity issue from rule aws-s3-no-public-buckets:

No public access block so not restricting public buckets

More information available here and here

Comment on lines +1 to +4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ tfsec found a LOW severity issue from rule aws-s3-specify-public-access-block:

Bucket does not have a corresponding public access block.

More information available here and here

Comment on lines +1 to +4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ tfsec found a HIGH severity issue from rule aws-s3-no-public-access-with-acl:

More information available here and here