Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX for users looking to replace the movie files in their submissions #1994

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

YoshiRulz
Copy link
Collaborator

@YoshiRulz YoshiRulz commented Sep 27, 2024

screenshot

@vadosnaprimer
Copy link
Collaborator

vadosnaprimer commented Sep 29, 2024

If people cancel and resubmit to fix a minor mistake, they haven't read Submission Instructions. I think the link we need within the description of that Movie file field is https://tasvideos.org/SubmissionInstructions#UpdatingTheSubmissionFile

Maybe just say there "if you need to do a minor fix to the movie, here's how"

Since embedding wiki specific links into code is not nice, a better approach would be to have a system page with the necessary text, and using it as the description of the field.

Copy link
Collaborator

@vadosnaprimer vadosnaprimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK so please put an alert-info instead, at the top of submission edit page, and have a system wiki page whose text will be embedded there, similar to how Submissions/Submit embeds System/SubmitMovieHeader

@YoshiRulz YoshiRulz force-pushed the submission-replacement-hint branch 2 times, most recently from 351268a to 3d0b363 Compare October 1, 2024 01:27
@YoshiRulz
Copy link
Collaborator Author

Sorry for the churn.

I copied what the Submit page had, is that all that's necessary?

Copy link
Collaborator

@vadosnaprimer vadosnaprimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly now!

изображение

@adelikat adelikat merged commit 78c9e1f into TASVideos:main Oct 1, 2024
1 check passed
@YoshiRulz YoshiRulz deleted the submission-replacement-hint branch October 1, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants