Add prev/next ID buttons for game groups (#2000)

* Change prefix to format string for `ViewDataDictionary.SetNavigation` also make these explicitly absolute paths, while still allowing relative paths * Add prev/next ID buttons for game groups
TASVideos · Oct 1, 2024 · e079b4a · e079b4a
1 parent 084a9a3
commit e079b4a
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 6 deletions.
diff --git a/TASVideos/Extensions/ViewDataDictionaryExtensions.cs b/TASVideos/Extensions/ViewDataDictionaryExtensions.cs
@@ -45,10 +45,10 @@ public static string GetHeading(this ViewDataDictionary viewData)
 	public static void SetWikiPage(this ViewDataDictionary viewData, IWikiPage wikiPage)
 		=> viewData["WikiPage"] = wikiPage;
 
-	public static void SetNavigation(this ViewDataDictionary viewData, int id, string suffix)
+	public static void SetNavigation(this ViewDataDictionary viewData, int id, string fmtStr = "{0}")
 	{
 		viewData["NavigationId"] = id;
-		viewData["NavigationSuffix"] = suffix;
+		viewData["NavigationFmtStr"] = fmtStr;
 	}
 
 	public static string ActivePageClass(this ViewDataDictionary viewData, string page)

diff --git a/TASVideos/Pages/GameGroups/Index.cshtml b/TASVideos/Pages/GameGroups/Index.cshtml
@@ -2,6 +2,10 @@
 @model IndexModel
 @{
 	ViewData.SetTitle($"Games for Group: {Model.Name}");
+	if (int.TryParse(Model.Id, out var id))
+	{
+		ViewData.SetNavigation(id, "/GameGroups/{0}");
+	}
 }
 
 <warning-alert condition="!Model.Games.Any()">

diff --git a/TASVideos/Pages/Games/Index.cshtml b/TASVideos/Pages/Games/Index.cshtml
@@ -20,7 +20,7 @@
 
 	if (int.TryParse(Model.Id, out int id))
 	{
-		ViewData.SetNavigation(id, "G");
+		ViewData.SetNavigation(id, "/{0}G");
 	}
 }
 

diff --git a/TASVideos/Pages/Shared/_Layout.cshtml b/TASVideos/Pages/Shared/_Layout.cshtml
@@ -89,6 +89,7 @@
 		var heading = ViewData.GetHeading();
 		int? prev = null;
 		int? next = null;
+		string? fmtStr = ViewData["NavigationFmtStr"] as string;
 		if (User.Has(PermissionTo.CatalogMovies))
 		{
 			var id = ViewData.Int("NavigationId");
@@ -101,7 +102,7 @@
 
 		<div class="container mb-2">
 			<h1 class="page-title card card-body d-block">
-				<a condition="prev.HasValue" href="@(prev + ViewData["NavigationSuffix"]?.ToString())"><i class="fa fa-arrow-left"></i></a>
+				<a condition="prev.HasValue" href="@string.Format(fmtStr!, prev)"><i class="fa fa-arrow-left"></i></a>
 				@if (IsSectionDefined("PageTitle"))
 				{
 					@await RenderSectionAsync("PageTitle")
@@ -110,7 +111,7 @@
 				{
 					@heading
 				}
-				<a condition="next.HasValue" class="float-end" href="@(next + ViewData["NavigationSuffix"]?.ToString())"><i class="fa fa-arrow-right"></i></a>
+				<a condition="next.HasValue" class="float-end" href="@string.Format(fmtStr!, next)"><i class="fa fa-arrow-right"></i></a>
 			</h1>
 		</div>
 	}

diff --git a/TASVideos/Pages/Submissions/View.cshtml b/TASVideos/Pages/Submissions/View.cshtml
@@ -4,7 +4,7 @@
 @{
 	ViewData.SetTitle($"{Model.Submission.Title} - Submission #{Model.Id}");
 	ViewData.SetHeading($"Submission {Model.Submission.Title}");
-	ViewData.SetNavigation(Model.Id, "S");
+	ViewData.SetNavigation(Model.Id, "/{0}S");
 	bool hasEncode = !string.IsNullOrWhiteSpace(Model.Submission.EncodeEmbedLink);
 	bool canEdit = User.Has(PermissionTo.EditSubmissions)
 		|| (Model.CanEdit && User.Has(PermissionTo.SubmitMovies));