Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: accent color in s-footer #390

Merged
merged 2 commits into from
Sep 6, 2024
Merged

enhance: accent color in s-footer #390

merged 2 commits into from
Sep 6, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Sep 6, 2024 •
edited
Loading

Overview / Changes

  • Make s-footer a dark context element.
  • Use accent color on hover over link in s-footer.

Important

Side Effect: Headings in a footer will become white.

Example
before after
before after

Related

Testing

  1. Open http://localhost:3000/components/detail/s-footer.
  2. Verify link color matches text color.
  3. Hover over links.
  4. Verify hover color is #86aeff.

UI

Before.mov
After.mov

@wesleyboar wesleyboar added the minor A feature in backward-compatible manner label Sep 6, 2024
@github-actions github-actions bot added the enhancement Improvements or additions to existing features label Sep 6, 2024
@wesleyboar wesleyboar merged commit 88dcef4 into main Sep 6, 2024
5 checks passed
@wesleyboar wesleyboar deleted the enhance/accent-color-in-footer branch September 6, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvements or additions to existing features minor A feature in backward-compatible manner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar