Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DES-2724 app-card__type mis-aligned #326

Closed
wants to merge 2 commits into from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 29, 2024

Overview

Fix mis-aligned "Types" block on an app card.

The mis-alignment is not always present, but once I could reproduce it, this made sense to fix it.

Status

Closed. See #326 (comment).

Related

Changes

  • changed margin bottom on card __types box to a static value

Testing

  1. Visit https://www.designsafe-ci.org/testing-pages/image-plugin-email-link/.
  2. Verify gray boxes still line up.
  3. Remove font size of text in gray box*:
    1. find c-app-card__type styles
    2. disable font-size: 1.2rem
  4. Verify gray boxes still line up.

* There may be other ways to product the bug. This worked for me.

UI

Bug is apparent Bug not apparent
Before bug is apparent bug not apparent
After

@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Mar 29, 2024
@wesleyboar wesleyboar added the patch A backward-compatible fix label Mar 29, 2024
@wesleyboar wesleyboar marked this pull request as ready for review March 29, 2024 18:00
wesleyboar added a commit to DesignSafe-CI/portal that referenced this pull request Mar 29, 2024
@wesleyboar
Copy link
Member Author

Important

This "fix" is not following the design. The design vertically centers the gray box in available space, then seems to have placed text so that the boxes also vertically align with each other. The latter seems unfeasible to achieve.

@wesleyboar wesleyboar closed this Mar 29, 2024
@wesleyboar wesleyboar deleted the fix/DES-2724-app-card-type-mis-aligned branch March 29, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant