Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): c-nav support buttons #195

Merged
merged 6 commits into from
Jul 20, 2023
Merged

fix(components): c-nav support buttons #195

merged 6 commits into from
Jul 20, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 19, 2023 •
edited
Loading

Overview

Support buttons inside c-nav components.

Related

Changes

  • added styles to fix layout where buttons are supported
  • added templating to render buttons where supported
  • added configuration to activate buttons where supported

Testing

  1. Buttons are rendered for c-nav--no-list.
  2. Buttons layout has no misalignment.

UI

narrow wide
no-list - narrow no-list - wide
piped boxed default
piped - no buttons boxed - no buttons default - no buttons

@wesleyboar wesleyboar added the patch A backward-compatible fix label Jul 19, 2023
@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Jul 19, 2023
@wesleyboar wesleyboar mentioned this pull request Jul 19, 2023
Merged
@wesleyboar wesleyboar marked this pull request as ready for review July 19, 2023 23:22
@wesleyboar wesleyboar merged commit 2de91a8 into main Jul 20, 2023
@wesleyboar wesleyboar deleted the fix/c-nav-button-support branch July 20, 2023 15:11
This was referenced Jul 20, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar