Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): c-nav demo & "--piped" modifier #191

Merged
merged 1 commit into from
Jul 19, 2023
Merged

feat(components): c-nav demo & "--piped" modifier #191

merged 1 commit into from
Jul 19, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 19, 2023 •
edited
Loading

Overview / Changes

  • Adds demo for c-nav.
  • Adds c-nav--piped variant.

Related

Testing

  1. Verify supported variant combinations1 are documented.
  2. Verify https://ecepalliance.org/alliance-members/ usage (c-nav c-nav--boxed) behavior is unchanged.

UI

variant wide narrow
default default wide default narrow
boxed boxed wide boxed narrow
piped piped wide piped narrow
no-list no-list wide no-list narrow
readme
readme

Footnotes

  1. All combinations are supported except "piped lists". ↩

@wesleyboar wesleyboar mentioned this pull request Jul 19, 2023
Merged
@github-actions github-actions bot added the feature A new feature or replacement of existing feature label Jul 19, 2023
@wesleyboar wesleyboar added the minor A feature in backward-compatible manner label Jul 19, 2023
@wesleyboar wesleyboar marked this pull request as ready for review July 19, 2023 20:00
@wesleyboar wesleyboar merged commit 88764c2 into main Jul 19, 2023
5 checks passed
@wesleyboar wesleyboar deleted the feat/c-nav-demo-and-piped-variant branch July 19, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature A new feature or replacement of existing feature minor A feature in backward-compatible manner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar