Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/feat: dlkcat docker multiarch #395

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

chore/feat: dlkcat docker multiarch #395

wants to merge 3 commits into from

Conversation

mihai-sysbio
Copy link
Member

@mihai-sysbio mihai-sysbio commented Oct 19, 2024 •
edited
Loading

Main improvements in this PR:

This PR adds an ARM-compatible Docker image of dlkcat thus resolving #393.

Instructions on merging this PR:

  • This PR has develop as target branch, and will be resolved with a squash-merge.
  • This PR has main as target branch, and will be resolved with a merge commit.

@mihai-sysbio mihai-sysbio mentioned this pull request Oct 19, 2024
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 19, 2024 •
edited
Loading

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 
GECKO installed, unknown version (cannot find version.txt).
Running geckoCoreFunctionTests
Done geckoCoreFunctionTests
__________

Note: In the case of multiple test runs, this post will be edited.

@mihai-sysbio
Copy link
Member Author

Once all the images are tested, it would be good to change the call dlkcat-gecko to 0.1-multiarch rather than just 0.1, but the old 0.1 image should not be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mihai-sysbio