Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge GECKO2 development into GECKO2 #228

Merged
merged 2 commits into from
Feb 26, 2023
Merged

chore: merge GECKO2 development into GECKO2 #228

merged 2 commits into from
Feb 26, 2023

Conversation

mihai-sysbio
Copy link
Member

@mihai-sysbio mihai-sysbio commented Feb 22, 2023

Main improvements in this PR:

This PR partially resolves #227 and aims to incorporate all GECKO2 development into the GECKO2 branch. Upon merging, the gecko2devel branch is to be deleted.

johan-gson and others added 2 commits November 2, 2021 16:15
…e optimizations concern getEnzymeCodes and matchKcats. The findInDBOld is still needed for KEGG matches, I haven't looked at that.

Some new optimizations were also introduced since there were other bottlenecks for yeast. I use containers.Map which may require a somewhat new matlab version.
Introduction of optimizations originally developed in Gecko Light.
@mihai-sysbio mihai-sysbio mentioned this pull request Feb 22, 2023
6 tasks
@edkerk
Copy link
Member

edkerk commented Feb 25, 2023

This has been reviewed previously, so fine for me to merge.

But what to do with #121, #122, #134 and #135? These are all developments on GECKO2 code, that hadn't made it into gecko2devel yet. For me it's fine to close and abandon #134 and #135.

@mihai-sysbio
Copy link
Member Author

mihai-sysbio commented Feb 26, 2023

This has been reviewed previously, so fine for me to merge.

Let's do that.

But what to do with #121, #122, #134 and #135? These are all developments on GECKO2 code, that hadn't made it into gecko2devel yet. For me it's fine to close and abandon #134 and #135.

Since this is not urgent, I created a separate issue for this #243

@edkerk edkerk merged commit 33a83aa into gecko2 Feb 26, 2023
@edkerk edkerk deleted the gecko2devel branch February 26, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

branch changes for GECKO3
3 participants