Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

932646: Enhancing the UI for a More Attractive Stock Management Application with tailwind3. #6

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

MohanrajRKM
Copy link
Collaborator

@MohanrajRKM MohanrajRKM commented Jan 17, 2025

Bug description

On the npmci site, the Smart Stock Picks section has a scrollbar even at 100% browser size with the recommended screen resolution of 125%.

Root cause

NA

Reason for not identifying earlier

Find how it was missed in our earlier testing and development by analyzing the below checklist. This will help prevent similar mistakes in the future.

  • Guidelines/documents are not followed

  • Common guidelines / Core team guideline

  • Specification document

  • Requirement document

  • Guidelines/documents are not given

  • Common guidelines / Core team guideline

  • Specification document

  • Requirement document

Reason:

Guidelines/documents are not given - Requirement document

Action taken:

NA

Related areas:

theme

Is it a breaking issue?

NA

Solution description

On the npmci site, the Smart Stock Picks section has a scrollbar even at 100% browser size with the recommended screen resolution of 125%, and the solution is to decrease the grid height to prevent it.

Output screenshots

Before
image

After
image
image

Areas affected and ensured

Ensured screen resolution at 150% and 125%, tested with browser sizes 100%, 110%, and 125%.

Additional checklist

This may vary for different teams or products. Check with your scrum masters.

  • Did you run the automation against your fix? - NA

  • Is there any API name change? - NA

  • Is there any existing behavior change of other features due to this code change? - NA

  • Does your new code introduce new warnings or binding errors? - NA

  • Does your code pass all FxCop and StyleCop rules? - NA

  • Did you record this case in the unit test or UI test? - NA

  • This issue applicable for blazor? - No

@MohanrajRKM MohanrajRKM added the enhancement New feature or request label Jan 17, 2025
@MohanrajRKM MohanrajRKM requested a review from jmfarook7 January 17, 2025 05:58
@MohanrajRKM MohanrajRKM self-assigned this Jan 17, 2025
Copy link
Collaborator

@jmfarook7 jmfarook7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix fine

@jmfarook7 jmfarook7 merged commit 8205038 into master Jan 17, 2025
1 check passed
@jmfarook7 jmfarook7 deleted the EJ2-932646-UI-scroll branch January 17, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants