Merge pull request #627 from Swirrl/fix-memory-leak

Fixes #623 memory leak when appending & deleting triples
Swirrl · Aug 15, 2022 · 96b6bda · 96b6bda
2 parents 4ac33bc + e40fe7f
commit 96b6bda
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/drafter/src/drafter/async/jobs.clj b/drafter/src/drafter/async/jobs.clj
@@ -149,9 +149,12 @@
   "Move a job in the pending list into the complete list, adding :complete
   and :finish-time metadata."
   [{job-id :id :as job}]
-  (let [job' (assoc job
-                    :status :complete
-                    :finish-time (System/currentTimeMillis))]
+  (let [job' (-> job
+                 (assoc :status :complete
+                        :finish-time (System/currentTimeMillis))
+                 (dissoc :function) ;; remove function closure as otherwise it will leak batches of quads
+                 (map->Job)
+                 )]
     (swap! jobs (fn [jobs]
                   (-> jobs
                       (update :pending dissoc job-id)

diff --git a/drafter/test/drafter/test_common.clj b/drafter/test/drafter/test_common.clj
@@ -294,7 +294,7 @@
 (def job-id-path #"/v1/status/finished-jobs/([a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12})")
 
 (defn job-path->job-id [job-path]
-  (if-let [uid (second (re-matches job-id-path job-path))]
+  (when-let [uid (second (re-matches job-id-path job-path))]
     (UUID/fromString uid)))
 
 (defn await-completion