Skip to content

Commit

Permalink
fixed few bugs; new screenshots; some changes in home screen (#550)
Browse files Browse the repository at this point in the history
  • Loading branch information
Swati4star authored Jan 2, 2019
1 parent 014aaaf commit 53e0134
Show file tree
Hide file tree
Showing 8 changed files with 30 additions and 9 deletions.
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ You can also join the Images To PDF Team on Slack [https://imagestopdf.slack.com
- Extract images from PDF
- History : View all the PDF related conversions

<img src="./screenshots/0_navigation.png" width="190px">
Here is a home page to get quick access to all the features "PDF Converter" provides:

<img src="./screenshots/0_1_home.png" width="190px"> <img src="./screenshots/0_2_home.png" width="190px">

### Creating a PDF file

Expand Down
Binary file removed app/src/main/ic_launcher-web.png
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@ public void cropButtonClicked() {
String root = Environment.getExternalStorageDirectory().toString();
File myDir = new File(root + pdfDirectory);
Uri uri = mCropImageView.getImageUri();

if (uri == null) {
showSnackbar(this, R.string.error_occurred);
return;
}

String path = uri.getPath();
String fname = "cropped_im";
if (path != null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ else if (mPath != null)
// close the renderer
renderer.close();
}
} catch (IOException | SecurityException | IllegalArgumentException e) {
} catch (IOException | SecurityException | IllegalArgumentException | OutOfMemoryError e) {
e.printStackTrace();
}

Expand Down
5 changes: 5 additions & 0 deletions app/src/main/res/drawable/ic_arrow_upward_white.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<vector android:height="24dp" android:tint="#FFFFFF"
android:viewportHeight="24.0" android:viewportWidth="24.0"
android:width="24dp" xmlns:android="http://schemas.android.com/apk/res/android">
<path android:fillColor="#FF000000" android:pathData="M4,12l1.41,1.41L11,7.83V20h2V7.83l5.58,5.59L20,12l-8,-8 -8,8z"/>
</vector>
22 changes: 15 additions & 7 deletions app/src/main/res/layout/fragment_home.xml
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,6 @@
android:layout_height="wrap_content"
android:orientation="horizontal">

<swati4star.createpdf.customviews.MyCardView
android:id="@+id/remove_duplicates_pages_pdf"
android:layout_width="0dp"
android:layout_height="match_parent"
android:layout_weight="1.0"
app:option_icon="@drawable/fp_ic_action_up"
app:option_text="@string/remove_duplicate_pages" />

<swati4star.createpdf.customviews.MyCardView
android:id="@+id/merge_pdf"
Expand All @@ -179,6 +172,21 @@
app:option_icon="@drawable/ic_call_split_black_24dp"
app:option_text="@string/split_pdf" />

</LinearLayout>

<LinearLayout
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="horizontal">

<swati4star.createpdf.customviews.MyCardView
android:id="@+id/remove_duplicates_pages_pdf"
android:layout_width="0dp"
android:layout_height="match_parent"
android:layout_weight="1.0"
app:option_icon="@drawable/ic_arrow_upward_white"
app:option_text="@string/remove_duplicate_pages" />

<swati4star.createpdf.customviews.MyCardView
android:id="@+id/compress_pdf"
android:layout_width="0dp"
Expand Down
Binary file added screenshots/0_1_home.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added screenshots/0_2_home.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 53e0134

Please sign in to comment.