CSS - Add useFontWeightAsNumbers flag #7
+21
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreddyNO
approved these changes
Aug 21, 2024
honzatmn
requested changes
Aug 25, 2024
There was a problem hiding this comment.
I don't thin we should merge this before we resolve the issue with invalid values for font weight (which is the currently wrong behavior actually)
However, if we want to introduce the useFontWeightAsNumbers flag, it could be useful if the behavior will change to the one described in my other comment. But I see that more like a new feature of the exporter
| allowReferences: exportConfiguration.useReferences, | ||
| decimals: exportConfiguration.colorPrecision, | ||
| colorFormat: exportConfiguration.colorFormat, | ||
| tokenToVariableRef: (t) => { | ||
| return `var(--${tokenVariableName(t, tokenGroups)})` | ||
| }, | ||
| }) | ||
|
|
||
| if (exportConfiguration.useFontWeightAsNumbers && token.tokenType === TokenType.fontWeight) { | ||
| let candidate = +(value?.replaceAll('"', '')) |
There was a problem hiding this comment.
As we discussed, it should never return the value wrapped in quotes for font-weight, that's invalid CSS then. So the current behavior of this flag (when turned off) will lead to incorrect values
- when i see
useFontWeightAsNumbersflag, my expectations are that string values (such as bold, semibold, normal, etc) will be returned as 700, 600, 500 instead of the word. But it's not what this does
Here is a mapping table from OpenType specs:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to existing exporters
useFontWeightAsNumbersflag