Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to disambiguate 'familiar' names #861

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

nonprofittechy
Copy link
Member

@nonprofittechy nonprofittechy commented Jun 12, 2024

Fix #857

Returns the individual's name in the most familiar form possible.

The purpose is to allow using a short version of the individual's name in an unambiguous
way in the interview. For example: referring to the child in a guardianship petition
by first name instead of "the minor". But there may be a problem if context doesn't make
it clear if you are talking about the child or their parent when they share a name.

In order, it will try to use:

  • just the first name
  • the first name and suffix
  • the first and middle name
  • the first and last name
  • the full name
  • the default value, e.g., "the minor", if provided
  • the full name

Example usage:

Who do you want to take care of ${ children.familiar(unique_names=parents + petitioners, default="the minor") }?

@nonprofittechy nonprofittechy marked this pull request as ready for review June 12, 2024 17:44
@ekressmiller
Copy link

This seems like a good idea. I hadn't thought of that pitfall of using just the first name but in retrospect it's so clear!

@nonprofittechy nonprofittechy merged commit b415c18 into main Jun 20, 2024
4 of 5 checks passed
@nonprofittechy nonprofittechy deleted the 857-familiar-disambiguation branch June 20, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should .familiar() default to showing the suffix in addition to first name?
2 participants