Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-hypenate sign-in #808

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Un-hypenate sign-in #808

merged 1 commit into from
Dec 23, 2023

Conversation

BryceStevenWilley
Copy link
Contributor

@BryceStevenWilley BryceStevenWilley commented Dec 22, 2023 •
edited
Loading

Very minor note that someone noticed when doing feedback of our interviews. Assembly Line doesn't hypenate it elsewhere:

docassemble-AssemblyLine/docassemble/AssemblyLine/data/questions/al_saved_sessions.yml

Line 60 in 3d0181d

${ action_button_html(url_of('login'), label="Sign in", icon="sign-in-alt", size="md", color="primary") }
, so this makes us consistent with other text on the screen and ourselves.

@BryceStevenWilley
Un-hypenate sign-in
70c5eea 
We don't hypenate it elsewhere.
@nonprofittechy nonprofittechy merged commit 9ecb545 into main Dec 23, 2023
5 checks passed
@nonprofittechy nonprofittechy deleted the sign_in branch December 23, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonprofittechy nonprofittechy nonprofittechy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BryceStevenWilley @nonprofittechy