quick and dirty patch #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed all uses of SpaCy, hopefully, stepping around the conflict that presented in the Weaver with updates to other packages. I was only able to do this, however, by making use of the tools.suffolklitlab.org micro-services: `vectorize` and `passive`. You can see the testing results in `dev-testing/test package.ipynb` Unfortunately, this means that there are now a number of features that require a tools_token to work. I have not updated the documentation to make this clear, but I will open an issue. Also, I'm not sure if we want to push this change to PiPy or have the Weaver install from this branch as a hot fix. Obviously, where Weaver calls these functions no using tools, we'll need to pass a token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed all uses of SpaCy, hopefully, stepping around the conflict that presented in the Weaver with updates to other packages. I was only able to do this, however, by making use of the tools.suffolklitlab.org micro-services:
vectorizeandpassive. You can see the testing results indev-testing/test package.ipynbUnfortunately, this means that there are now a number of features that require a tools_token to work. I have not updated the documentation to make this clear, but I will open an issue. Also, I'm not sure if we want to push this change to PiPy or have the Weaver install from this branch as a hot fix. Obviously, where Weaver calls these functions no using tools, we'll need to pass a token.