Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssetParsing improvements #2133

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dartasen
Copy link
Member

@dartasen dartasen commented Apr 30, 2024

The original idea was to understand why the server loading could seem infinite when I try to start a server, I had assumed the possibility of race condition since we're using parallelism at some point but in this current state it was quite complicated to determine given the current implementation which has a rather confusing control flow.
So I took the opportunity to try to clean this up while trying both investigate issues & upgrade to the latest version of AssetTools

Progress :

  • Bump to latest version of AssetTools
  • Refactor asset parsers to avoid using static constructors in favor to Disposable parsers, since Nitrox is using them for a one shot load
  • Drop System.Drawing reference in favor of ImageSharp which is cross-platform for RandomSpawnTexture reading
  • Improve UX by adding more informations about what's going behind the scene (especially when game is on a slow external disk, it can takes several minutes to load)
  • Fix loading errors happening with the refactor

@dartasen dartasen marked this pull request as draft April 30, 2024 12:51
@tornac1234 tornac1234 added Type: bug Area: dependencies Pull requests that update a dependency file labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: dependencies Pull requests that update a dependency file Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants