Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select colormap for slope colors, and select line widths #354

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

akboudalis
Copy link

Three additional Opt fields are added, which control:
-Slope colormap
-Zeeman line width
-Transition line width

@akboudalis akboudalis changed the title select comormap for slope colors and line widths Select colormap for slope colors, and select line widths Jan 15, 2025
@stestoll
Copy link
Member

Thanks for this!

  1. You should add defaults for the new options.
  2. I don't think you can pass Opt as first input argument to windowButtonMotionFcn, since MATLAB calls the function with two input arguments src and event.
  3. Please don't change the default line widths.

@akboudalis
Copy link
Author

I have tried to correct/update/revert according to the comments.

Hopefully this comes closer.

@stestoll
Copy link
Member

Right now, the function crashes if called without the Opt argument. Please add defaults for the new fields. Here is how it's done for the other fields:

if ~isfield(Opt,'SlopeColor')
  Opt.SlopeColor = false;
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants