Merge pull request BloomBooks#531 from BloomBooks/BL12871_DontHideSL

Prevent duplicate filter from errantly hiding SL books (BL-12871) (BloomBooks#531)
StephenMcConnel · Jan 10, 2024 · 8ecbc00 · 8ecbc00
2 parents 6202aaf + 1e3517b
commit 8ecbc00
Showing 1 changed file with 14 additions and 3 deletions.
diff --git a/src/model/DuplicateBookFilter.ts b/src/model/DuplicateBookFilter.ts
@@ -41,12 +41,23 @@ export function PreferBooksWithL1MatchingFocusLanguage_DuplicateBookFilter(
     for (const book of books) {
         let hash = book.phashOfFirstContentImage;
         if (languageInFocus) {
-            const titleInContextLang = getBookTitleInLanguageOrUndefined(
+            let titleInContextLang = getBookTitleInLanguageOrUndefined(
                 book,
                 languageInFocus
             );
-            if (!titleInContextLang && languageInFocus !== kTagForNoLanguage) {
-                continue; // just skip it. There are surprisingly many books that have some English but don't have the title in English. E.g. 6jFUJ8jeEv
+            if (!titleInContextLang) {
+                if (book.features.includes("signLanguage")) {
+                    // Sign language books don't have a title in the sign language.
+                    titleInContextLang = getBookTitleInLanguageOrUndefined(
+                        book,
+                        book.lang1Tag || "en"
+                    );
+                    if (!titleInContextLang) {
+                        titleInContextLang = book.allTitles?.[0] ?? "";
+                    }
+                } else if (languageInFocus !== kTagForNoLanguage) {
+                    continue; // just skip it. There are surprisingly many books that have some English but don't have the title in English. E.g. 6jFUJ8jeEv
+                }
             }
             hash += (titleInContextLang ?? "").toLowerCase();
         }