Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Decky Terminal #416

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Add Decky Terminal #416

merged 3 commits into from
Aug 17, 2023

Conversation

Alex4386
Copy link
Contributor

Decky Terminal

This plugin adds missing terminal emulator in game-mode. providing access to terminal while playing games.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

@Alex4386 Alex4386 temporarily deployed to testing_env August 17, 2023 14:11 — with GitHub Actions Inactive
@TrainDoctor TrainDoctor requested a review from a team August 17, 2023 14:30
@TrainDoctor
Copy link
Member

@SteamDeckHomebrew/loader-team need a code review pretty please.

@PartyWumpus PartyWumpus self-assigned this Aug 17, 2023
Copy link
Member

@PartyWumpus PartyWumpus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and it works well. If @Alex4386 is happy with it, I'll merge it.

Would be nice if a user could change the shell it uses, but it looks like that wouldn't be too hard to implement later :) (although my p10k theme for zsh doesn't work because it wants a specific font. I can probably fix that with CSS loader, that's not your problem)

Not totally sure why your decky_terminal python stuff is in your defaults folder, but there's no harm in it being there I suppose.

Maybe remove these commented sections: https://github.com/Alex4386/decky-terminal/blob/f084f99be5f9cd14b6ae8252034b734c3597c21c/src/panel.tsx#L36 & https://github.com/Alex4386/decky-terminal/blob/f084f99be5f9cd14b6ae8252034b734c3597c21c/src/panel.tsx#L20 and remove the DeckyPluginRouterTest stuff as it's uneeded.

@PartyWumpus
Copy link
Member

(Got my p10k zsh theme working using a css loader theme to change the font to MesloLGS NF)
before
image
after
image

Copy link

@nabel0 nabel0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine on SteamOS Stable/Beta Update Channel.

@PartyWumpus PartyWumpus merged commit 905d375 into SteamDeckHomebrew:main Aug 17, 2023
2 checks passed
@Alex4386
Copy link
Contributor Author

Alex4386 commented Aug 17, 2023

Not totally sure why your decky_terminal python stuff is in your defaults folder, but there's no harm in it being there I suppose.

Currently decky cli doesn't include py_modules at the root properly at the moment. This is some sort of workaround. See SteamDeckHomebrew/cli#5. also, The design was supposed to separate the communication logic (on Plugin) and the internals. that's why decky_terminal implements "singleton" class for the plugin (for the internals).

Maybe remove these commented sections: https://github.com/Alex4386/decky-terminal/blob/f084f99be5f9cd14b6ae8252034b734c3597c21c/src/panel.tsx#L36 & https://github.com/Alex4386/decky-terminal/blob/f084f99be5f9cd14b6ae8252034b734c3597c21c/src/panel.tsx#L20 and remove the DeckyPluginRouterTest stuff as it's uneeded.

Forgot about that, That stub was supposed to be a page for GitHub page and acknowledgement page for the plugin. Will include that in future versions.

Would be nice if a user could change the shell it uses, but it looks like that wouldn't be too hard to implement later :) (although my p10k theme for zsh doesn't work because it wants a specific font. I can probably fix that with CSS loader, that's not your problem)

As a user of Powerlevel10K on my main dev-machine, adding custom font support and ligature support seems like a great idea. I'll add that into my roadmap right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants