feat: expanded plugin unzipping #556
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you feel this is ready to go to a testable PR please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please tick as appropriate:
Description
Current unzipping takes into account only a single structure of zip file in which the plugin is contained within a subfolder of the same name under the zip. This expands this to include both nested zipfiles (uploading artifacts from GHA) as well as the plugin within the root directory of the zip.
In particular this stops having to do this just to be able to publish a zip file through the Artifacts:
https://github.com/CEbbinghaus/MicroSDeck/blob/6f3e010ec8e8f6b6d2e7a293541754a6215ccdef/.github/workflows/build.yml#L37-L47