Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting to Python files in CI #365

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Add linting to Python files in CI #365

wants to merge 17 commits into from

Commits on Feb 2, 2023

  1. Add lint job to build workflow

    @SkyLeite
    SkyLeite committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    52777bc View commit details
    Browse the repository at this point in the history

  2. Add prettier-plugin-import-sort

    @SkyLeite
    SkyLeite committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    1320b13 View commit details
    Browse the repository at this point in the history

  3. Install prettier plugins before linting

    @SkyLeite
    SkyLeite committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    7675775 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Use lint script from package.json

    @SkyLeite
    SkyLeite committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    d48fc88 View commit details
    Browse the repository at this point in the history

  2. Move linters to separate workflow

    @SkyLeite
    SkyLeite committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    1379a40 View commit details
    Browse the repository at this point in the history

  3. Remove Python and Shell linters

    @SkyLeite
    SkyLeite committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    b33d44c View commit details
    Browse the repository at this point in the history

  4. Remove popd

    @SkyLeite
    SkyLeite committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    6edc3bb View commit details
    Browse the repository at this point in the history

  5. Test that prettier properly fails the lint job

    @SkyLeite
    SkyLeite committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    1f596e5 View commit details
    Browse the repository at this point in the history

  6. Revert "Test that prettier properly fails the lint job" 

    This reverts commit 1f596e5.
    @SkyLeite
    SkyLeite committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    e20fd50 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2023

  1. Fix most formatting and linting errors

    @SkyLeite
    SkyLeite committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    b6fce46 View commit details
    Browse the repository at this point in the history

  2. Add python linting actions

    @SkyLeite
    SkyLeite committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    8fab487 View commit details
    Browse the repository at this point in the history

  3. Fix E722 linter rule

    @SkyLeite
    SkyLeite committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    93587fe View commit details
    Browse the repository at this point in the history

  4. Fix F811 linter rule 

    get_user_group was defined twice, so I merged both definitions
    @SkyLeite
    SkyLeite committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    e3e1cf2 View commit details
    Browse the repository at this point in the history

  5. Fix F821 lint rule

    @SkyLeite
    SkyLeite committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    1edcc09 View commit details
    Browse the repository at this point in the history

  6. Fix unescaped curly braces in javascript formatting 

    This would previously throw an error due to `format` interpreting the
curly braces as placeholders
    @SkyLeite
    SkyLeite committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    4e92d4b View commit details
    Browse the repository at this point in the history

  7. Disable SyntaxError lint rule due to ruff not supporting pattern matc… 

    …hing
    @SkyLeite
    SkyLeite committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    897e177 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into python-lint-format-test

    @SkyLeite
    SkyLeite authored Feb 4, 2023
    Configuration menu
    Copy the full SHA
    f1db083 View commit details
    Browse the repository at this point in the history