Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for copying remote binaries #7

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

wheaney
Copy link
Contributor

@wheaney wheaney commented Sep 4, 2023

Justifications for this change:

  • decky-loader already supports this but it seems to be broken
  • why create a bad user experience failing on installation when you can fail the same check at build time?
  • more self-contained plugins: what the user downloads contains everything needed to install

@TrainDoctor TrainDoctor added the enhancement New feature or request label Sep 4, 2023
wheaney added a commit to wheaney/decky-plugin-database that referenced this pull request Sep 4, 2023
…inary copying during the backend build process

Necessary until this PR is merged: SteamDeckHomebrew/cli#7
Copy link
Collaborator

@SkyLeite SkyLeite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for contributing :)

@@ -94,6 +97,50 @@ impl Builder {
.await
}

pub async fn copy_remote_binaries(&self) -> Result<()> {
let package_json_file = std::fs::read_to_string(self.plugin_root.join("package.json")).expect("Failed to read package.json");
let json: Value = serde_json::from_str(&package_json_file).expect("Failed to parse package.json");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably write a type for package.json eventually :p

@SkyLeite SkyLeite merged commit c543601 into SteamDeckHomebrew:main Sep 6, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants