Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fs mount for backend build step to allow for building frontend an… #10

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

NGnius
Copy link
Contributor

@NGnius NGnius commented Nov 18, 2023

…d other parts of code

Before this, only things in the <plugin root>/backend/ could be accessed by the custom backend build step. This opens that up to anything in <plugin root>/ while maintaining the original mounts for backwards compatibility. I assume the original intent of restricting it to only the backend folder was to limit it's usage to backend compilation, but I don't really see the merit to that when it could also be used for other compile-time tasks like code generation and building frontend dependencies.

This enables the latest version of Fantastic (and future USDPL v0.11+ plugins) to generate it's frontend WebAssembly at compile time. For reference: docker build script for Fantastic v0.5.0.

(This is not pressure, just information: lack of this functionality is blocking Fantastic v0.5.0 from being released onto the Decky store)

Copy link
Collaborator

@SkyLeite SkyLeite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@SkyLeite SkyLeite merged commit 83ed57b into SteamDeckHomebrew:main Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants