This repository has been archived by the owner on Jul 3, 2022. It is now read-only.
Ci #3
Open
Ci #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
@WerWolv has brought to my attention that the solutions proposed here for enabling ssh via sudoers while viable are not a desired solution to running plugins with root access and root plugins are being worked on in the loader at the moment. If removed I think the CI related stuff could be merged but the sudoers related stuff will have to go. Of course Wolv will be the final arbiter of this, just weighing in with his comments and my own 2 cents. 👍🏻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CI, bundling, and install scripts now that there is a bit more setup for users to configure the sudoes file. With this, we can create a release that users can download from a single link rather than via git-clone such as: https://github.com/Philip-Scott/media-controls-plugin/releases