Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Spezi documentation #68

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Updated Spezi documentation #68

wants to merge 4 commits into from

Conversation

AdritRao
Copy link
Member

@AdritRao AdritRao commented Jan 22, 2024

Updated Spezi documentation

♻️ Current situation & Problem

Currently, the individual module pages are auto-generated in the Spezi documentation. These pages do not contain iPhone screenshots nor a brief description of the module's purpose.

⚙️ Release Notes

  • Added links to the specific modules below the screenshots in the overview: TemplateApplication.md
  • Added the screenshots along with a brief description to the individual module pages (e.g. Consent.swift)

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AdritRao for starting to work on this. Goes in the right direction and will be very helpful for people to get started 🚀

///
/// Modify the contact details for your app in the Contacts view.
///
/// ![A screenshot of the Contact screen](Contacts)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To render the documentation it would require to remove the empty line between the docs & the type. Also applies to other files.

@@ -10,8 +10,12 @@ import Foundation
import SpeziContact
import SwiftUI

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that you have two empty lines between the import statements and the first lines of the swift files. Also applies to other files.

@@ -10,8 +10,12 @@ import Foundation
import SpeziContact
import SwiftUI

/// Display contacts for your app.
///
/// Modify the contact details for your app in the Contacts view.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! It might even make sense to link to the relevant module documentations here. Also applies to other files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice additions @AdritRao!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants