added auth state listener to directly navigate to home when logged in #50
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
============================================
+ Coverage 43.67% 44.61% +0.95%
- Complexity 310 318 +8
============================================
Files 125 125
Lines 3813 3829 +16
Branches 552 558 +6
============================================
+ Hits 1665 1708 +43
+ Misses 1999 1970 -29
- Partials 149 151 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Thank you for working on this @Basler182; I would defer to @eldcn and @pauljohanneskraft for a detailed review 👍
i spoke to @eldcn earlier. he is working on the changes we discussed on tuesday and is removing the firebase auth module from the app. he will then merge the changes into this branch and then we can merge everything together into the master 🚀 |
|
Sounds great; thank you @Basler182 and @eldcn! |
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
|
@Basler182, @PSchmiedmayer , @pauljohanneskraft I just merged #55 pointing to this branch 🙌 |
# Firebase dependencies in Account module ## ♻️ Current situation & Problem Moves all firebase dependencies in account module, and exposes needed information and APIs from other modules via custom components. This way, consumers of `account` module, do not need to include firebase dependencies additionally in case they use `account`. Firebase remains this way as an internal implementation detail, that can be easily replaced without affecting other modules and minimizing breaking changes in regard to backwards compatibility ## ⚙️ Release Notes *Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.* *Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.* ## 📚 Documentation *Please ensure that you properly document any additions in conformance to [Spezi Documentation Guide](https://github.com/StanfordSpezi/.github/blob/main/DOCUMENTATIONGUIDE.md).* *You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.* ## ✅ Testing *Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.* *This section describes important information about the tests and why some elements might not be testable.* ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [ ] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
There was a problem hiding this comment.
Thank you @eldcn for the improvements and working on this feature!
Feel free to sync merging this PR with @Basler182 to get this PR merged; thanks to the two of you to get this in place 🚀
# Conflicts: # app/src/main/kotlin/edu/stanford/bdh/engagehf/MainActivityViewModel.kt # app/src/main/kotlin/edu/stanford/bdh/engagehf/onboarding/EngageConsentManager.kt # app/src/test/kotlin/edu/stanford/bdh/engagehf/MainActivityViewModelTest.kt
Signed-off-by: Basler182 <[email protected]>
auth state listener
♻️ Current situation & Problem
#37
⚙️ Release Notes
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: