Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 42 local storage encryption #47

Merged
merged 26 commits into from
Jun 23, 2024

Conversation

Basler182
Copy link
Contributor

Feature/issue 42 local storage encryption

♻️ Current situation & Problem

#42

⚙️ Release Notes

  • Added Key-Value Storage (EncryptedFileStorage)
  • File Storage (EncryptedSharedPreferencesStorage as well as LocalStorage)

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.54%. Comparing base (9c33498) to head (08bbd29).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #47   +/-   ##
=========================================
  Coverage     27.54%   27.54%           
  Complexity      228      228           
=========================================
  Files           105      105           
  Lines          3102     3102           
  Branches        439      439           
=========================================
  Hits            854      854           
  Misses         2196     2196           
  Partials         52       52           
Flag Coverage Δ
unittests 27.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c33498...08bbd29. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Basler182 for working on this; this will be helpful for ENGAGE-HF and a lot of future projects!

@Basler182 Basler182 enabled auto-merge (squash) June 21, 2024 09:24
Copy link
Contributor

@eldcn eldcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Are you planning to adapt factory approach with support for multiple storage files as part of this PR?

@Basler182 Basler182 merged commit 19b0573 into main Jun 23, 2024
7 checks passed
@Basler182 Basler182 deleted the feature/issue-42-local-storage-encryption branch June 23, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants