Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed skip check invitiation code for testing #46

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

Basler182
Copy link
Contributor

@Basler182 Basler182 commented Jun 15, 2024

Removed skipping of the invitation code check

♻️ Current situation & Problem

#34

⚙️ Release Notes

  • removed skipping of the invitation code check

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 25.97%. Comparing base (9965c5a) to head (845e041).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #46      +/-   ##
============================================
- Coverage     26.00%   25.97%   -0.03%     
  Complexity      195      195              
============================================
  Files           102      102              
  Lines          2920     2916       -4     
  Branches        403      403              
============================================
- Hits            759      757       -2     
+ Misses         2124     2122       -2     
  Partials         37       37              
Flag Coverage Δ
unittests 25.97% <80.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...e/onboarding/invitation/InvitationCodeViewModel.kt 66.67% <80.00%> (+2.16%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9965c5a...845e041. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Basler182!

@Basler182 Basler182 merged commit 1f3a66f into main Jun 21, 2024
7 checks passed
@Basler182 Basler182 deleted the fix/issue-34-invitation-code-validation branch June 21, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants