Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #90 don't dismiss failed message action #137

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Basler182
Copy link
Contributor

don't dismiss failed message action

♻️ Current situation & Problem

#90

⚙️ Release Notes

  • don't dismiss failed message action

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 39.49%. Comparing base (156f738) to head (5d70f0e).

Files with missing lines Patch % Lines
...nford/bdh/engagehf/bluetooth/BluetoothViewModel.kt 68.43% 2 Missing and 4 partials ⚠️
...ezi/modules/education/videos/EducationViewModel.kt 33.34% 2 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #137      +/-   ##
============================================
- Coverage     39.50%   39.49%   -0.00%     
- Complexity      768      773       +5     
============================================
  Files           261      261              
  Lines         10388    10393       +5     
  Branches       1457     1460       +3     
============================================
+ Hits           4103     4104       +1     
- Misses         5916     5919       +3     
- Partials        369      370       +1     
Flag Coverage Δ
uitests 33.42% <0.00%> (-0.03%) ⬇️
unittests 33.44% <60.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ezi/modules/education/videos/EducationViewModel.kt 60.98% <33.34%> (+3.09%) ⬆️
...nford/bdh/engagehf/bluetooth/BluetoothViewModel.kt 75.25% <68.43%> (-1.75%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 156f738...5d70f0e. Read the comment docs.

@Basler182 Basler182 self-assigned this Oct 27, 2024
@Basler182 Basler182 added the ENGAGE HF ENGAGE-HF-specific issues label Oct 27, 2024
@Basler182 Basler182 marked this pull request as ready for review October 27, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENGAGE HF ENGAGE-HF-specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant