Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/union type image resource video preview #136

Conversation

Basler182
Copy link
Contributor

union type image resource video preview

♻️ Current situation & Problem

#133 (comment)

⚙️ Release Notes

  • added RemoteImageSource and extended ImageSourceComposeable accordingly

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Signed-off-by: Basler182 <[email protected]>
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 32.22222% with 61 lines in your changes missing coverage. Please review.

Project coverage is 38.88%. Comparing base (c51436c) to head (78f0aaa).
Report is 1 commits behind head on task/union-type-image-resource.

Files with missing lines Patch % Lines
...i/core/design/component/ImageResourceComposable.kt 0.00% 61 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                         Coverage Diff                          @@
##             task/union-type-image-resource     #136      +/-   ##
====================================================================
+ Coverage                             38.75%   38.88%   +0.13%     
  Complexity                              797      797              
====================================================================
  Files                                   259      259              
  Lines                                 10395    10407      +12     
  Branches                               1452     1452              
====================================================================
+ Hits                                   4028     4046      +18     
+ Misses                                 5985     5983       -2     
+ Partials                                382      378       -4     
Flag Coverage Δ
uitests 30.88% <32.23%> (+0.56%) ⬆️
unittests 33.32% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nford/spezi/core/design/component/ImageResource.kt 0.00% <ø> (ø)
...tanford/spezi/modules/contact/ContactComposable.kt 58.63% <100.00%> (ø)
...ucation/videos/component/ExpandableVideoSection.kt 62.36% <100.00%> (+15.02%) ⬆️
...i/core/design/component/ImageResourceComposable.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51436c...78f0aaa. Read the comment docs.

@Basler182 Basler182 marked this pull request as ready for review October 27, 2024 17:19
@Basler182 Basler182 self-assigned this Oct 27, 2024
@Basler182 Basler182 requested a review from eldcn October 27, 2024 17:19
@eldcn
Copy link
Contributor

eldcn commented Oct 27, 2024

👏

@eldcn eldcn merged commit 31ad5ea into task/union-type-image-resource Oct 27, 2024
11 checks passed
@eldcn eldcn deleted the task/union-type-image-resource-video-preview branch October 27, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants