Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Contact #126

Merged
merged 18 commits into from
Oct 21, 2024
Merged

Feature Contact #126

merged 18 commits into from
Oct 21, 2024

Conversation

Basler182
Copy link
Contributor

Feature Contact

♻️ Current situation & Problem

⚙️ Release Notes

Contact Module

Contact Screen Contact Screen

Engage-HF

Contact Screen

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Basler182 Basler182 added documentation Improvements or additions to documentation enhancement New feature or request ENGAGE HF ENGAGE-HF-specific issues labels Oct 19, 2024
@Basler182 Basler182 self-assigned this Oct 19, 2024
@Basler182 Basler182 linked an issue Oct 19, 2024 that may be closed by this pull request
1 task
# Conflicts:
#	app/src/main/res/values/strings.xml
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 32.78008% with 162 lines in your changes missing coverage. Please review.

Project coverage is 38.92%. Comparing base (9eae0b5) to head (13c7d76).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../stanford/bdh/engagehf/contact/ui/ContactScreen.kt 0.00% 77 Missing ⚠️
...tanford/spezi/modules/contact/ContactComposable.kt 22.65% 41 Missing ⚠️
...h/engagehf/contact/data/EngageContactRepository.kt 43.48% 13 Missing ⚠️
...dh/engagehf/navigation/components/AccountDialog.kt 0.00% 12 Missing ⚠️
...ehf/contact/data/ContactDocumentToContactMapper.kt 66.67% 0 Missing and 8 partials ⚠️
...n/kotlin/edu/stanford/bdh/engagehf/MainActivity.kt 0.00% 5 Missing ⚠️
.../bdh/engagehf/contact/ui/ContactScreenViewModel.kt 91.67% 0 Missing and 2 partials ⚠️
...lin/edu/stanford/bdh/engagehf/navigation/Routes.kt 0.00% 2 Missing ⚠️
...ord/spezi/modules/contact/component/AddressCard.kt 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #126      +/-   ##
============================================
- Coverage     39.10%   38.92%   -0.18%     
- Complexity      784      797      +13     
============================================
  Files           252      256       +4     
  Lines         10159    10358     +199     
  Branches       1410     1442      +32     
============================================
+ Hits           3972     4031      +59     
- Misses         5816     5945     +129     
- Partials        371      382      +11     
Flag Coverage Δ
uitests 30.85% <39.44%> (-0.07%) ⬇️
unittests 33.49% <30.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ford/bdh/engagehf/navigation/AppNavigationEvent.kt 100.00% <ø> (ø)
.../engagehf/navigation/screens/AppScreenViewModel.kt 89.40% <100.00%> (+1.03%) ⬆️
...ezi/modules/contact/component/ContactOptionCard.kt 60.61% <100.00%> (+3.94%) ⬆️
...du/stanford/spezi/modules/contact/model/Contact.kt 100.00% <100.00%> (ø)
...pezi/modules/contact/model/PersonNameComponents.kt 93.75% <100.00%> (ø)
.../bdh/engagehf/contact/ui/ContactScreenViewModel.kt 91.67% <91.67%> (ø)
...lin/edu/stanford/bdh/engagehf/navigation/Routes.kt 33.34% <0.00%> (-3.03%) ⬇️
...ord/spezi/modules/contact/component/AddressCard.kt 51.03% <50.00%> (-0.04%) ⬇️
...n/kotlin/edu/stanford/bdh/engagehf/MainActivity.kt 0.00% <0.00%> (ø)
...ehf/contact/data/ContactDocumentToContactMapper.kt 66.67% <66.67%> (ø)
... and 4 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eae0b5...13c7d76. Read the comment docs.

Copy link
Contributor

@eldcn eldcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Signed-off-by: Basler182 <[email protected]>
@Basler182 Basler182 enabled auto-merge (squash) October 21, 2024 18:26
Signed-off-by: Basler182 <[email protected]>
@Basler182 Basler182 merged commit 0148cf3 into main Oct 21, 2024
11 checks passed
@Basler182 Basler182 deleted the feature/contact-doc branch October 21, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ENGAGE HF ENGAGE-HF-specific issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpeziContact: Improve ContactOptionCard layout
3 participants