Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpeziStorage - All changes #125

Closed
wants to merge 31 commits into from
Closed

SpeziStorage - All changes #125

wants to merge 31 commits into from

Conversation

pauljohanneskraft
Copy link
Contributor

@pauljohanneskraft pauljohanneskraft commented Oct 15, 2024

SpeziStorage - All changes

♻️ Current situation & Problem

This pull request contains all changes made to SpeziStorage for easier review. It is not intended to be merged.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 88.10573% with 27 lines in your changes missing coverage. Please review.

Project coverage is 39.84%. Comparing base (1841feb) to head (39b2901).

Files with missing lines Patch % Lines
...rd/spezi/modules/storage/secure/AndroidKeyStore.kt 76.09% 4 Missing and 7 partials ⚠️
...anford/spezi/modules/storage/local/LocalStorage.kt 92.73% 1 Missing and 3 partials ⚠️
...d/spezi/modules/storage/key/KeyValueStorageImpl.kt 90.33% 1 Missing and 2 partials ⚠️
...ford/spezi/modules/storage/secure/SecureStorage.kt 92.50% 0 Missing and 3 partials ⚠️
...ezi/modules/storage/key/InMemoryKeyValueStorage.kt 71.43% 2 Missing ⚠️
...i/core/bluetooth/domain/BLEPairedDevicesStorage.kt 75.00% 0 Missing and 1 partial ⚠️
...stanford/spezi/modules/storage/di/StorageModule.kt 90.00% 1 Missing ⚠️
...d/spezi/modules/storage/key/KeyValueStorageType.kt 66.67% 1 Missing ⚠️
...i/modules/storage/secure/SecureStorageItemTypes.kt 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #125      +/-   ##
============================================
+ Coverage     33.65%   39.84%   +6.19%     
- Complexity      663      750      +87     
============================================
  Files           231      254      +23     
  Lines          9618    10140     +522     
  Branches       1343     1410      +67     
============================================
+ Hits           3236     4039     +803     
+ Misses         6144     5741     -403     
- Partials        238      360     +122     
Flag Coverage Δ
uitests 34.11% <88.35%> (?)
unittests 33.61% <75.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pezi/modules/storage/key/KeyValueStorageFactory.kt 100.00% <100.00%> (ø)
...spezi/modules/storage/local/LocalStorageSetting.kt 100.00% <100.00%> (ø)
...anford/spezi/modules/storage/secure/Credentials.kt 100.00% <100.00%> (ø)
...i/core/bluetooth/domain/BLEPairedDevicesStorage.kt 98.42% <75.00%> (+1.23%) ⬆️
...stanford/spezi/modules/storage/di/StorageModule.kt 90.91% <90.00%> (ø)
...d/spezi/modules/storage/key/KeyValueStorageType.kt 66.67% <66.67%> (ø)
...i/modules/storage/secure/SecureStorageItemTypes.kt 75.00% <75.00%> (ø)
...ezi/modules/storage/key/InMemoryKeyValueStorage.kt 93.34% <71.43%> (ø)
...d/spezi/modules/storage/key/KeyValueStorageImpl.kt 90.33% <90.33%> (ø)
...ford/spezi/modules/storage/secure/SecureStorage.kt 92.50% <92.50%> (ø)
... and 2 more

... and 29 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1841feb...39b2901. Read the comment docs.

@pauljohanneskraft pauljohanneskraft deleted the storage/review branch October 21, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants