Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure SnapshotListener on Account is actually added #46

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Make sure SnapshotListener on Account is actually added #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/SpeziFirebaseAccountStorage/FirestoreAccountStorage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@

Task { @Sendable in
guard let snapshot else {
await self.logger.error("Failed to retrieve user document collection: \(error)")

Check warning on line 149 in Sources/SpeziFirebaseAccountStorage/FirestoreAccountStorage.swift

View workflow job for this annotation

GitHub Actions / Build and Test Swift Package / Test using xcodebuild or run fastlane 

non-sendable type 'Logger' in implicitly asynchronous access to actor-isolated property 'logger' cannot cross actor boundary

Check warning on line 149 in Sources/SpeziFirebaseAccountStorage/FirestoreAccountStorage.swift

View workflow job for this annotation

GitHub Actions / Build and Test UI Tests / Test using xcodebuild or run fastlane 

non-sendable type 'Logger' in implicitly asynchronous access to actor-isolated property 'logger' cannot cross actor boundary
return
}

Expand Down Expand Up @@ -196,7 +196,7 @@
let localCache = localCache
let cached = await localCache.loadEntry(for: accountId, keys)

if listenerRegistrations[accountId] != nil { // check that there is a snapshot listener in place
if listenerRegistrations[accountId] == nil { // check that there is a snapshot listener in place
snapshotListener(for: accountId, with: keys)
}

Expand Down
Loading